docs(best-practices): §2 spine-vs-membrane split — close the lance-graph #592 coordination loop#102
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…aph #592 coordination loop PR #592 (parallel session) closed `ISS-CONTRACT-APP-PREFIX-MIRROR` by mirroring OGAR #97's `PortSpec::APP_PREFIX` / `render_classid_for` into `lance_graph_contract::ogar_codebook` as `AppPrefix` + `render_classid_for_concept` (wire-compat, parity-pinned, no `ogar-vocab` dep). Its coordination note left the OGAR-side companion — the spine-vs-membrane import-path distinction in OGAR #100 §2 — to this session. This commit closes that loop. Changes to docs/OGAR-CONSUMER-BEST-PRACTICES.md: §2 — new preface block: pins the BBB-barrier rule (spine-internal crates freely depend on `ogar-vocab`; membrane crates restricted to `lance-graph-contract` only), with the allowed-deps × canonical-path table. Both paths return identical classids — the choice is dep-tree posture, not concept identity. Pattern 1 split — Pattern 1a (spine, `ogar_vocab::ports::*Port::class_id`) + Pattern 1b (membrane, `lance_graph_contract::ogar_codebook::canonical_concept_id`). Pattern 2 split — Pattern 2a (spine, `*Port::APP_PREFIX | concept`) + Pattern 2b (membrane, `AppPrefix::*.render(cid)` or `render_classid_for_concept(AppPrefix::*, name)` — the one-call helper). Cites lance-graph #592, names the parity test `app_prefixes_match_ogar_allocation_table` as the drift fuse. §5 trigger phrases — extended with `BBB-barrier` · `contract::ogar_codebook` · `canonical_concept_id` · `AppPrefix` · `render_classid_for_concept` · `lance_graph_contract::ogar_codebook` · `membrane consumer` · `spine vs membrane`. §6 cross-refs — sharpened lance-graph #591 entry (surfaced the gap) and added lance-graph #592 entry (closed it with the membrane mirror). Patterns 3 + 4, §3 anti-pattern catalogue, §4 worked Medcare migration narrative — unchanged (they're correct as-is; the membrane variant inherits from the new 1b/2b without further branching). Docs-only. Closes the consumer/membrane half of the ISS-CONTRACT-APP-PREFIX-MIRROR coordinated fix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EYvNjD8M8LMNYbRy3gq2FP
AdaWorldAPI
force-pushed
the
claude/ogar-best-practices-bbb-barrier
branch
from
3effeae to
aaf1f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the OGAR-side coordination loop with lance-graph #592 (merged). That PR closed
ISS-CONTRACT-APP-PREFIX-MIRRORby mirroring OGAR #97'sPortSpec::APP_PREFIX+render_classid_forintolance_graph_contract::ogar_codebookasAppPrefix+render_classid_for_concept— wire-compat, parity-pinned, noogar-vocabdep (BBB-safe).The companion change owed on the OGAR side — the spine-vs-membrane import-path distinction in
OGAR-CONSUMER-BEST-PRACTICES.md§2 — lands here.§2 split — spine vs membrane
New §2 preface block pins the BBB-barrier rule:
lance-graph-*,ogar-vocab,ogar-ontology,ogar-class-view)ogar-vocab·ogar-ontology·lance-graph-*ogar_vocab::ports::*Portwoa-rs,smb-office-rs,medcare-realtime) — enforced by allow-lists (woa-rs Iron Rule 1, etc.)lance-graph-contractonlylance_graph_contract::ogar_codebookBoth paths return identical classids — the choice is dep-tree posture, not concept identity.
Pattern 1 split into 1a (spine) + 1b (membrane):
Pattern 2 split into 2a (spine) + 2b (membrane):
Pattern 2b cites #592, names the parity test
app_prefixes_match_ogar_allocation_tableas the drift fuse, and shows the 6-app worked-examples mirror.Incidental
Replaced the existing tick/cross markers (
CANONICALvsANTIlabels in code-comment annotations) with plain text labels throughout §2 + §3 + Pattern 3. Same semantic distinction, cleaner doc.Out of scope
BBB-barrier,contract::ogar_codebook,AppPrefix,render_classid_for_concept,membrane consumer,spine vs membrane).Status
Doc-only. Closes the consumer/membrane half of the
ISS-CONTRACT-APP-PREFIX-MIRRORcoordinated fix (the contract/lance-graph half landed in #592).